Skip to content

fix(cli): detect Windows Yarn global installs in update notices - #1692

Merged
mldangelo-oai merged 1 commit into
openai:mainfrom
WenJing95:fix/windows-yarn-update-command
Oct 19, 2026
Merged

mldangelo-oai merged 1 commit into
openai:mainfrom
WenJing95:fix/windows-yarn-update-command

Conversation

@WenJing95

Copy link
Copy Markdown
Contributor

Summary

On Windows, Yarn Classic puts global packages under %LOCALAPPDATA%\Yarn\Data\global, which updateCommand doesn't recognize. The update notice then suggests npm install @openai/codex-security@latest without -g, which doesn't update the global CLI.

Changes

updateCommand now treats /yarn/data/global/ as a global Yarn install and suggests yarn global add. Added a Windows row to the install-path test.

Testing

Tests pass.

Risk and rollout

Other install paths get the same command as before.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the bug Something isn't working label Oct 17, 2026

@mldangelo-oai mldangelo-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Windows Yarn Classic install path now produces the global Yarn update command. The command-selection regression check passes, and I reproduced the incorrect npm suggestion on the parent commit.

@mldangelo-oai
mldangelo-oai merged commit 47ad7aa into openai:main Oct 19, 2026
57 checks passed
@github-actions github-actions Bot mentioned this pull request Oct 19, 2026
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants